Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes the cacheConfigRTFCollector UT #713

Merged

Conversation

atharvasharma61
Copy link
Contributor

@atharvasharma61 atharvasharma61 commented Sep 4, 2024

Description

fixes the cacheConfigRTFCollector UT

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
NA

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@psychbot
Copy link
Member

psychbot commented Sep 4, 2024

Build is failing.

@Gaganjuneja Gaganjuneja merged commit 7fd7bc7 into opensearch-project:main Sep 4, 2024
5 of 7 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-713-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7fd7bc76a0b213ff4bb5cb76f3b877d7ff82d6e6
# Push it to GitHub
git push --set-upstream origin backport/backport-713-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-713-to-2.x.

atharvasharma61 added a commit to atharvasharma61/performance-analyzer that referenced this pull request Sep 4, 2024
nishchay21 pushed a commit that referenced this pull request Sep 4, 2024
atharvasharma61 added a commit to atharvasharma61/performance-analyzer that referenced this pull request Sep 5, 2024
ansjcy pushed a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants