Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logstash from downloads page and fix blog #3432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

derek-ho
Copy link
Contributor

@derek-ho derek-ho commented Nov 5, 2024

Description

Removes logstash from downloads page and adds more info for blog on connecting your own self managed OSD.

Issues Resolved

Fix: #3427
Fix: #3426

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

@derek-ho
Copy link
Contributor Author

derek-ho commented Nov 5, 2024

@cwperks can you help take a look for technical accuracy? Also @pajuric I am not too familiar with the downloads page. Will removing this file remove the entry from the page?

@nateynateynate
Copy link
Member

Hey @derek-ho - _include/downloads/logstash-oss-with-opensearch-output-plugin.markdown is referenced in many other locations. I don't think we can safely delete it unless we find the references to it.

I forget where the logic is that constructs the view of the download page, but give me a bit and I'll drop some hints in here.

Copy link
Member

@nateynateynate nateynateynate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always a good idea to try to build the site locally so we can see what build errors are going to pop up. The output of that will lead us to what's going wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file cannot be safely deleted unless we find all the places its being used. Try running bundle exec jekyll serve from the root of the repo and going through the list of errors. It should give us some hints.

@nateynateynate
Copy link
Member

This might help:
image

It looks like a lot of the files in _versions reference that file as the explanation metadata. I'd start there.

@derek-ho
Copy link
Contributor Author

@cwperks @dblock I am working on this PR but a little confused on how to proceed here. Should we remove the logstash in general, or only going forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants