-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport #992 to 2.11] #1004
Merged
Merged
[Backport #992 to 2.11] #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate chained findings monitor (opensearch-project#992) * remove chekc for agg rules in detector trigger condition to create bucket level monitor Signed-off-by: Surya Sashank Nistala <[email protected]> * add agg rules tags in chained monitor query to match trigger condition of detector Signed-off-by: Surya Sashank Nistala <[email protected]> * fix check to evaluate agg rules present when creating chained findings monitor Signed-off-by: Surya Sashank Nistala <[email protected]> * fix tests where check on group by trigger existed earlier Signed-off-by: Surya Sashank Nistala <[email protected]> * fix race condition while creating first monitor Signed-off-by: Surya Sashank Nistala <[email protected]> * add test to verify detector trigger function for aggregation rules Signed-off-by: Surya Sashank Nistala <[email protected]> * revert step listener change Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]>
goyamegh
approved these changes
Apr 28, 2024
goyamegh
previously requested changes
Apr 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check why the CIs are failing.
eirsep
force-pushed
the
2.11
branch
2 times, most recently
from
April 28, 2024 21:24
68b7976
to
0ba2963
Compare
Flaky tests unrelated to change
|
Signed-off-by: Surya Sashank Nistala <[email protected]>
eirsep
dismissed
goyamegh’s stale review
April 29, 2024 22:04
fixed CI. only failure is correlation engine flaky test
praveensameneni
approved these changes
Apr 29, 2024
goyamegh
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix check for agg rules in detector trigger condition to create chained findings monitor (#992)
remove chekc for agg rules in detector trigger condition to create bucket level monitor
add agg rules tags in chained monitor query to match trigger condition of detector
fix check to evaluate agg rules present when creating chained findings monitor
fix tests where check on group by trigger existed earlier
fix race condition while creating first monitor
add test to verify detector trigger function for aggregation rules
revert step listener change
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.