Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add field based rules support in correlation engine #740

Closed
wants to merge 1 commit into from

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Nov 29, 2023

Description

add field based rules support in correlation engine
2.9 manual backport of pr #737

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (a941222) 25.85% compared to head (de7e8d4) 25.75%.

Files Patch % Lines
...arch/securityanalytics/correlation/JoinEngine.java 0.00% 43 Missing ⚠️
...arch/securityanalytics/model/CorrelationQuery.java 0.00% 15 Missing ⚠️
...earch/securityanalytics/model/CorrelationRule.java 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.9     #740      +/-   ##
============================================
- Coverage     25.85%   25.75%   -0.11%     
  Complexity      940      940              
============================================
  Files           252      252              
  Lines         10753    10796      +43     
  Branches       1198     1209      +11     
============================================
  Hits           2780     2780              
- Misses         7726     7769      +43     
  Partials        247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbcd90 sbcd90 closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant