[Backport 2.7] #725 Sigma keywords field not handled correctly #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
* updated log type filters; fixed search field Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated log type filters; fixed search field Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed typo Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Joanne Wang <[email protected]> * remove wildcard Signed-off-by: Joanne Wang <[email protected]> * changed wildcardtest Signed-off-by: Joanne Wang <[email protected]> * fixed wildcards Signed-off-by: Joanne Wang <[email protected]> * fixed wildcard query test Signed-off-by: Joanne Wang <[email protected]> * fixed correlation engine tests Signed-off-by: Joanne Wang <[email protected]> * fixed query backend tests Signed-off-by: Joanne Wang <[email protected]> * clean up Signed-off-by: Joanne Wang <[email protected]> * added two integration tests Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.7 #745 +/- ##
============================================
- Coverage 28.13% 28.07% -0.07%
Complexity 895 895
============================================
Files 231 231
Lines 9343 9336 -7
Branches 1075 1074 -1
============================================
- Hits 2629 2621 -8
- Misses 6477 6480 +3
+ Partials 237 235 -2 ☔ View full report in Codecov by Sentry. |
|
Security tests have been failing for previous PRs |
riysaxen-amzn
approved these changes
Mar 11, 2024
goyamegh
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports #725 to 2.7
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.