[Backport 2.8] #725 Sigma keywords field not handled correctly #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joanne Wang <[email protected]> * remove wildcard Signed-off-by: Joanne Wang <[email protected]> * changed wildcardtest Signed-off-by: Joanne Wang <[email protected]> * fixed wildcards Signed-off-by: Joanne Wang <[email protected]> * fixed wildcard query test Signed-off-by: Joanne Wang <[email protected]> * fixed correlation engine tests Signed-off-by: Joanne Wang <[email protected]> * fixed query backend tests Signed-off-by: Joanne Wang <[email protected]> * clean up Signed-off-by: Joanne Wang <[email protected]> * added two integration tests Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #751 +/- ##
============================================
- Coverage 28.19% 28.08% -0.11%
Complexity 895 895
============================================
Files 231 231
Lines 9338 9335 -3
Branches 1074 1073 -1
============================================
- Hits 2633 2622 -11
- Misses 6469 6479 +10
+ Partials 236 234 -2 ☔ View full report in Codecov by Sentry. |
goyamegh
approved these changes
Mar 11, 2024
riysaxen-amzn
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #725 to 2.8
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.