[Backport 2.6] #725 Sigma keywords field not handled correctly #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joanne Wang <[email protected]> * remove wildcard Signed-off-by: Joanne Wang <[email protected]> * changed wildcardtest Signed-off-by: Joanne Wang <[email protected]> * fixed wildcards Signed-off-by: Joanne Wang <[email protected]> * fixed wildcard query test Signed-off-by: Joanne Wang <[email protected]> * fixed correlation engine tests Signed-off-by: Joanne Wang <[email protected]> * fixed query backend tests Signed-off-by: Joanne Wang <[email protected]> * clean up Signed-off-by: Joanne Wang <[email protected]> * added two integration tests Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: Joanne Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.6 #753 +/- ##
============================================
- Coverage 35.67% 35.62% -0.05%
- Complexity 881 885 +4
============================================
Files 186 186
Lines 7274 7267 -7
Branches 878 877 -1
============================================
- Hits 2595 2589 -6
- Misses 4440 4443 +3
+ Partials 239 235 -4 ☔ View full report in Codecov by Sentry. |
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Feb 20, 2024
* Improved display of log types. Signed-off-by: AWSHurneyt <[email protected]> * Fixed cypress tests. Signed-off-by: AWSHurneyt <[email protected]> * Updated cypress workflow. Signed-off-by: AWSHurneyt <[email protected]> * Fixed cypress tests. Fixed flyout. Fixed rule form. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots. Signed-off-by: AWSHurneyt <[email protected]> * Updated log type labels usage. Adjusted cypress tests. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>
goyamegh
approved these changes
Mar 11, 2024
riysaxen-amzn
approved these changes
Mar 11, 2024
riysaxen-amzn
pushed a commit
to riysaxen-amzn/security-analytics
that referenced
this pull request
Mar 25, 2024
opensearch-project#753) (opensearch-project#760) * Added document _id as param for terms query when searching alerts by their ids Signed-off-by: Stevan Buzejic <[email protected]> * Empty-Commit Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #725 to 2.6
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.