Make login screen input feels consistent (#1993) (#1994)

opensearch-project · Jun 11, 2024 · 92b2c1d · 92b2c1d
1 parent 1abcc59
commit 92b2c1d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 42 deletions.
diff --git a/public/apps/login/login-page.tsx b/public/apps/login/login-page.tsx
@@ -17,7 +17,6 @@ import React, { useState } from 'react';
 import {
   EuiText,
   EuiFieldText,
-  EuiIcon,
   EuiSpacer,
   EuiButton,
   EuiImage,
@@ -194,7 +193,7 @@ export function LoginPage(props: LoginPageDeps) {
                 data-test-subj="user-name"
                 aria-label="username_input"
                 placeholder="Username"
-                prepend={<EuiIcon type="user" />}
+                icon="user"
                 onChange={(e) => setUsername(e.target.value)}
                 value={username}
                 isInvalid={usernameValidationFailed}

diff --git a/public/apps/login/test/__snapshots__/login-page.test.tsx.snap b/public/apps/login/test/__snapshots__/login-page.test.tsx.snap
@@ -44,14 +44,10 @@ exports[`Login page renders renders with config value for multiauth 1`] = `
       <EuiFieldText
         aria-label="username_input"
         data-test-subj="user-name"
+        icon="user"
         isInvalid={false}
         onChange={[Function]}
         placeholder="Username"
-        prepend={
-          <EuiIcon
-            type="user"
-          />
-        }
         value=""
       />
     </EuiFormRow>
@@ -195,14 +191,10 @@ exports[`Login page renders renders with config value for multiauth with anonymo
       <EuiFieldText
         aria-label="username_input"
         data-test-subj="user-name"
+        icon="user"
         isInvalid={false}
         onChange={[Function]}
         placeholder="Username"
-        prepend={
-          <EuiIcon
-            type="user"
-          />
-        }
         value=""
       />
     </EuiFormRow>
@@ -364,14 +356,10 @@ exports[`Login page renders renders with config value with anonymous auth enable
       <EuiFieldText
         aria-label="username_input"
         data-test-subj="user-name"
+        icon="user"
         isInvalid={false}
         onChange={[Function]}
         placeholder="Username"
-        prepend={
-          <EuiIcon
-            type="user"
-          />
-        }
         value=""
       />
     </EuiFormRow>
@@ -483,14 +471,10 @@ exports[`Login page renders renders with config value with anonymous auth enable
       <EuiFieldText
         aria-label="username_input"
         data-test-subj="user-name"
+        icon="user"
         isInvalid={false}
         onChange={[Function]}
         placeholder="Username"
-        prepend={
-          <EuiIcon
-            type="user"
-          />
-        }
         value=""
       />
     </EuiFormRow>
@@ -602,14 +586,10 @@ exports[`Login page renders renders with config value: string 1`] = `
       <EuiFieldText
         aria-label="username_input"
         data-test-subj="user-name"
+        icon="user"
         isInvalid={false}
         onChange={[Function]}
         placeholder="Username"
-        prepend={
-          <EuiIcon
-            type="user"
-          />
-        }
         value=""
       />
     </EuiFormRow>
@@ -703,14 +683,10 @@ exports[`Login page renders renders with config value: string array 1`] = `
       <EuiFieldText
         aria-label="username_input"
         data-test-subj="user-name"
+        icon="user"
         isInvalid={false}
         onChange={[Function]}
         placeholder="Username"
-        prepend={
-          <EuiIcon
-            type="user"
-          />
-        }
         value=""
       />
     </EuiFormRow>
@@ -804,14 +780,10 @@ exports[`Login page renders renders with default value: string 1`] = `
       <EuiFieldText
         aria-label="username_input"
         data-test-subj="user-name"
+        icon="user"
         isInvalid={false}
         onChange={[Function]}
         placeholder="Username"
-        prepend={
-          <EuiIcon
-            type="user"
-          />
-        }
         value=""
       />
     </EuiFormRow>
@@ -905,14 +877,10 @@ exports[`Login page renders renders with default value: string array 1`] = `
       <EuiFieldText
         aria-label="username_input"
         data-test-subj="user-name"
+        icon="user"
         isInvalid={false}
         onChange={[Function]}
         placeholder="Username"
-        prepend={
-          <EuiIcon
-            type="user"
-          />
-        }
         value=""
       />
     </EuiFormRow>