-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bad import path #1498
Fix a bad import path #1498
Conversation
- Resolves opensearch-project#1487 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]>
49a52a3
to
947d2d7
Compare
@peternied Please fix the eslint issue. I'm looking into how this got past CI on the offending PR. |
Signed-off-by: Peter Nied <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1498 +/- ##
=======================================
Coverage 65.61% 65.61%
=======================================
Files 93 93
Lines 2309 2309
Branches 315 315
=======================================
Hits 1515 1515
Misses 726 726
Partials 68 68 |
Approved. Updating the branch. |
* Fix a bad import path - Resolves #1487 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Ryan Liang <[email protected]> (cherry picked from commit 32c02c8)
* Fix a bad import path - Resolves #1487 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Ryan Liang <[email protected]> (cherry picked from commit 32c02c8) Co-authored-by: Peter Nied <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1498-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 32c02c8c18a509884613517fac38b684338d5273
# Push it to GitHub
git push --set-upstream origin backport/backport-1498-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
* Fix a bad import path - Resolves #1487 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Ryan Liang <[email protected]> (cherry picked from commit 32c02c8)
* Fix a bad import path - Resolves #1487 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Ryan Liang <[email protected]> (cherry picked from commit 32c02c8) Co-authored-by: Peter Nied <[email protected]>
* Fix a bad import path - Resolves opensearch-project#1487 Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Ryan Liang <[email protected]> Signed-off-by: Sam <[email protected]>
Description
Found a case where the import was done using a relative reference, instead of using a package reference causing a build break in some circumstances.
Issues Resolved
Testing
Using relative path import is fundamentally wrong, as long as CI works this fix works. Verified that there are no other references to
../packages/
in the codebase as well.Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.