Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenSearch logo theming for light / dark modes #1568

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

AMoo-Miki
Copy link
Contributor

Description

This change uses the imagery exposed by OSD for the login screen.

Issues Resolved

#1529

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks
cwperks previously approved these changes Aug 31, 2023
Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AMoo-Miki This change looks good to me. The failing integ tests are unrelated to this change and currently being worked on: opensearch-project/security#3272

@cwperks cwperks dismissed their stale review August 31, 2023 13:47

Looking into failing unit tests

@cwperks
Copy link
Member

cwperks commented Aug 31, 2023

@AMoo-Miki Can you address the failing unit tests in login-page.test.tsx?

● Login page › handle submit event › submit click event

TypeError: Cannot read properties of undefined (reading 'logos')

  260 |           size="fullWidth"
  261 |           alt=""
> 262 |           url={props.config.ui.basicauth.login.brandimage || props.chrome.logos.OpenSearch.url}
      |                                                                           ^
  263 |         />
  264 |       )}
  265 |       <EuiSpacer size="s" />

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1568 (75e295a) into main (f655ccf) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main    #1568   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files          93       93           
  Lines        2339     2339           
  Branches      312      312           
=======================================
  Hits         1548     1548           
  Misses        722      722           
  Partials       69       69           
Files Changed Coverage Δ
public/apps/customerror/custom-error.tsx 0.00% <0.00%> (ø)
public/apps/login/login-app.tsx 0.00% <0.00%> (ø)
public/apps/login/login-page.tsx 75.78% <100.00%> (ø)

@peternied
Copy link
Member

@AMoo-Miki Do you want to get this in for 2.10? The window is closing in pretty fast

@cwperks
Copy link
Member

cwperks commented Aug 31, 2023

@peternied This is blocked by opensearch-project/security#3278

Once the security PR is merged I will re-run the CI

@peternied peternied mentioned this pull request Aug 31, 2023
24 tasks
@peternied
Copy link
Member

Issue from the security plugin has been merged into main [1], I've retriggered the integration tests.

@cwperks cwperks merged commit ecb15d5 into opensearch-project:main Sep 1, 2023
13 of 14 checks passed
@cwperks cwperks added the backport 2.x backport to 2.x branch label Sep 1, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 1, 2023
Signed-off-by: Miki <[email protected]>
(cherry picked from commit ecb15d5)
cwperks pushed a commit that referenced this pull request Sep 5, 2023
Signed-off-by: Miki <[email protected]>
(cherry picked from commit ecb15d5)

Co-authored-by: Miki <[email protected]>
@stephen-crawford stephen-crawford mentioned this pull request Sep 5, 2023
3 tasks
@peternied peternied changed the title Refactor login logo usage Support OpenSearch logo theming for light / dark modes Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants