Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress13 testing frame work for OIDC and SAML #1579

Merged
merged 120 commits into from
Nov 29, 2023

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Sep 10, 2023

Description

  1. Setup the cypress 13 environment for security frontend
  2. Add OIDC Auth Tests
  3. Refactor SAML Auth Tests into Cypress

Category

Enhancement

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cf1748) 67.06% compared to head (9f6eed5) 67.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1579   +/-   ##
=======================================
  Coverage   67.06%   67.06%           
=======================================
  Files          94       94           
  Lines        2402     2402           
  Branches      318      318           
=======================================
  Hits         1611     1611           
  Misses        713      713           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RyanL1997 RyanL1997 changed the title WIP - Cypress12 OIDC testing WIP - Cypress13 OIDC testing Sep 13, 2023
@RyanL1997 RyanL1997 marked this pull request as ready for review September 26, 2023 16:49
.cypress/e2e/oidc/oidc_test.spec.js Outdated Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
@peternied
Copy link
Member

@RyanL1997 looks like progress has stalled, did you want to keep working on this as a draft or close it out?

@RyanL1997
Copy link
Collaborator Author

Hi @peternied, I will make sure this one included in the next sprint and keep working on it.

@RyanL1997 RyanL1997 marked this pull request as draft November 9, 2023 18:16
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
@RyanL1997
Copy link
Collaborator Author

Hi @peternied, the version checking step of keycloak before config and run-up has been added. Right now, if the version is mismatch with the env variable we defined, it will exit immediately.

@RyanL1997
Copy link
Collaborator Author

Once the review fixes has been verified, I will push another commit to clean up the debugging statements.

cwperks
cwperks previously approved these changes Nov 29, 2023
@cwperks cwperks added the backport 2.x backport to 2.x branch label Nov 29, 2023
@RyanL1997 RyanL1997 merged commit d863368 into opensearch-project:main Nov 29, 2023
12 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1579-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8633681c5b84bb20b6c0e5fd6faf500270cf94e
# Push it to GitHub
git push --set-upstream origin backport/backport-1579-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1579-to-2.x.

RyanL1997 added a commit to RyanL1997/security-dashboards-plugin that referenced this pull request Dec 8, 2023
* Cypress13 testing frame work for OIDC and SAML
---------
Signed-off-by: Ryan Liang <[email protected]>
cwperks pushed a commit that referenced this pull request Dec 18, 2023
* Cypress13 testing frame work for OIDC and SAML (#1579)

* Cypress13 testing frame work for OIDC and SAML
---------
Signed-off-by: Ryan Liang <[email protected]>

* Correct the workflow version

Signed-off-by: Ryan Liang <[email protected]>

* Update yarn lock

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Implement Cypress 13 frame work to security dashboard plugin
5 participants