CI fixes for adapting admin password change and fix the Cypress browser #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Liang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1596 +/- ##
=======================================
Coverage 66.18% 66.18%
=======================================
Files 93 93
Lines 2339 2339
Branches 312 317 +5
=======================================
Hits 1548 1548
Misses 722 722
Partials 69 69 |
Signed-off-by: Ryan Liang <[email protected]>
RyanL1997
changed the title
Signed-off-by: Ryan Liang <[email protected]>
3 tasks
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
RyanL1997
requested review from
cliu123,
cwperks,
davidlago,
peternied and
stephen-crawford
as code owners
DarshitChanpura
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
LGTM!. Thank you @RyanL1997 for being on top of this fix. It will unblock CI builds.
cwperks
approved these changes
Oct 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
…er (#1596) * Add the random admin password flow Signed-off-by: Ryan Liang <[email protected]> * Pass --headless=old Signed-off-by: Ryan Liang <[email protected]> * Switch to firefox for cypress Signed-off-by: Ryan Liang <[email protected]> * Fix the typo of firefox driver Signed-off-by: Ryan Liang <[email protected]> * Directly changed admin password into admin in ci Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 1e7b421)
DarshitChanpura
pushed a commit
that referenced
this pull request
Oct 3, 2023
…er (#1596) (#1598) Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 1e7b421) Co-authored-by: Ryan Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI fixes for adapting admin password change
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Test fix
Issues Resolved
Additional Context
--headless=oldin browser launch options cypress-io/cypress#27804Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.