Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 2.11.0.0 release notes #1600

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

DarshitChanpura
Copy link
Member

Check List

- [ ] New functionality includes testing
- [ ] New functionality has been documented

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1600 (70b4923) into main (d575e00) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1600   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files          93       93           
  Lines        2339     2339           
  Branches      317      317           
=======================================
  Hits         1548     1548           
  Misses        722      722           
  Partials       69       69           

RyanL1997
RyanL1997 previously approved these changes Oct 6, 2023
@DarshitChanpura DarshitChanpura marked this pull request as ready for review October 6, 2023 19:52
@DarshitChanpura DarshitChanpura added backport 2.x backport to 2.x branch backport 2.11 Backport to 2.11 branch labels Oct 6, 2023
Signed-off-by: Darshit Chanpura <[email protected]>
@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Oct 11, 2023

@peternied What do you think about force-merging the change? There is no code affected with this change but the CI still fails.

@stephen-crawford
Copy link
Contributor

stephen-crawford commented Oct 11, 2023

console.log
    Error: failed parsing SAML config
        at SecurityClient.getSamlHeader (/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/plugins/security-dashboards-plugin/server/backend/opensearch_security_client.ts:212:15)
        at processTicksAndRejections (node:internal/process/task_queues:95:5)
        at /home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/plugins/security-dashboards-plugin/server/auth/types/saml/routes.ts:78:30
        at Router.handle (/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/src/core/server/http/router/router.ts:286:44)
        at handler (/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/src/core/server/http/router/router.ts:241:11)
        at Object.<anonymous>.exports.Manager.execute (/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/node_modules/@hapi/hapi/lib/toolkit.js:60:28)
        at Object.<anonymous>.internals.handler (/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/node_modules/@hapi/hapi/lib/handler.js:46:20)
        at Object.<anonymous>.exports.execute (/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/node_modules/@hapi/hapi/lib/handler.js:31:20)
        at Request._lifecycle (/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/node_modules/@hapi/hapi/lib/request.js:371:32)
        at Request._execute (/home/runner/work/security-dashboards-plugin/security-dashboards-plugin/OpenSearch-Dashboards/node_modules/@hapi/hapi/lib/request.js:281:9)

      at SecurityClient.getSamlHeader (plugins/security-dashboards-plugin/server/backend/opensearch_security_client.ts:214:17)

Failure attempting to read SAML config

@peternied peternied merged commit d3b3f84 into opensearch-project:main Oct 12, 2023
9 of 13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2023
(cherry picked from commit d3b3f84)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2023
(cherry picked from commit d3b3f84)
peternied pushed a commit that referenced this pull request Oct 12, 2023
(cherry picked from commit d3b3f84)

Co-authored-by: Darshit Chanpura <[email protected]>
peternied pushed a commit that referenced this pull request Oct 12, 2023
(cherry picked from commit d3b3f84)

Co-authored-by: Darshit Chanpura <[email protected]>
leanneeliatra pushed a commit to leanneeliatra/security-dashboards-plugin-fork that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch backport 2.11 Backport to 2.11 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants