Dynamic Sign in options #1703
Open
Dynamic Sign in options #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
davidosorno
requested review from
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
|
Some of the CI checks will fail until opensearch-project/security#3869 is merged. |
|
Fixed. The login page validate that the sign-in option is still available. |
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: EduardoCorazon <[email protected]>
UI tweaks for OUI patterns
1 task
Signed-off-by: David Osorno <[email protected]>
|
This commit will cover [FEATURE] Provide login options for anonymous use case. |
There was a problem hiding this comment.
Hi @davidosorno, could you please look into the file conflict, and the hygiene-check errors. Assuming that the CI will be in a better shape for this PR once opensearch-project/security#3869 is merged and an artifact is available with that change.
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
Signed-off-by: David Osorno <[email protected]>
davidosorno
force-pushed
the
DynamicSignInOptions
branch
from
3905b6b
to
16695d9
Compare
|
@davidosorno Could you please resolve the conflict? |
Signed-off-by: Stephen Crawford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Feature
Allow admins to define the sign-in options that will be displayed on OpenSearch Dashboard login page. There are couple of sign-in options defined in Security documentation, and theses options must be available in security config.yml file to be able to change them dynamically in Security Dashboard.
Old Behavior
Admins have to update opensearch_dashboards.yml adding or removing sign-in options, and then restart Dashboards to be able to log in using other sign-in option.
New Behavior
Admins can change sign-in options dynamically without having to restart the Dashboards, and the changes are applied immediately. Users just need to logout in order to see the sign-in options available.
Issues Resolved
Dynamic Sign in options for OpenSearch Dashboards
Related
Security
Testing
Unit Testing, Integration Testing, and Manual Testing.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.