Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cypress E2E workflow to reflect changes to default admin password #1714

Conversation

DarshitChanpura
Copy link
Member

Description

Updates the github cypress test workflow to reflect to changes in admin password.

Category

Refactoring

Why these changes are required?

Cypress E2E workflow will be broken without this change.

Check List

- [ ] New functionality includes testing
- [ ] New functionality has been documented

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@DarshitChanpura DarshitChanpura added the v2.12.0 Items targeting 2.12.0 label Jan 3, 2024
@DarshitChanpura DarshitChanpura self-assigned this Jan 3, 2024
Signed-off-by: Darshit Chanpura <[email protected]>
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac38d9d) 67.09% compared to head (b84e335) 67.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1714   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files          94       94           
  Lines        2404     2404           
  Branches      318      318           
=======================================
  Hits         1613     1613           
  Misses        713      713           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks cwperks added the backport 2.x backport to 2.x branch label Jan 3, 2024
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could we follow up with a fix to pull the password from the env rather than hardcode it into the cypress config?

@DarshitChanpura DarshitChanpura merged commit 96a449f into opensearch-project:main Jan 4, 2024
18 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 4, 2024
…ord (#1714)

Signed-off-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 96a449f)
DarshitChanpura added a commit that referenced this pull request Jan 4, 2024
…ord (#1714) (#1719)

Signed-off-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 96a449f)

Co-authored-by: Darshit Chanpura <[email protected]>
DarshitChanpura added a commit to DarshitChanpura/security-dashboards-plugin that referenced this pull request Jan 4, 2024
…ord (opensearch-project#1714) (opensearch-project#1719)

Signed-off-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 96a449f)

Co-authored-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch v2.12.0 Items targeting 2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants