Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix cannot find module when import ResourceType in server from public folder (#1705) #1716

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jan 3, 2024

Backport #1705 to 2.x

ruanyl and others added 2 commits January 3, 2024 11:29
… folder (opensearch-project#1705)

* fix Cannot find module

Signed-off-by: Yulong Ruan <[email protected]>

* fix prettier error

Signed-off-by: Yulong Ruan <[email protected]>

* fix failed tests

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
(cherry picked from commit 09b2f59)
@cwperks
Copy link
Member Author

cwperks commented Jan 3, 2024

I created a manual backport for this PR even though its not required in the 2.x branch (at the moment). The reason it was moved from public/ to common/ is because its referenced in this PR in server/routes/index.ts. That PR is only merged into main and hasn't been merged into 2.x.

@peternied peternied merged commit 1f55360 into opensearch-project:2.x Jan 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants