Run cypress-tests and cypress-tests-tenancy-disabled on Chrome

[cwperks]

Description

Fixes an error seen on cypress tests runs like this:

...
Still waiting to connect to Firefox, retrying in 1 second (attempt 58/62)
Still waiting to connect to Firefox, retrying in 1 second (attempt 59/62)
Still waiting to connect to Firefox, retrying in 1 second (attempt 60/62)
Still waiting to connect to Firefox, retrying in 1 second (attempt 61/62)
Still waiting to connect to Firefox, retrying in 1 second (attempt 62/62)
Cypress failed to make a connection to Firefox.

This usually indicates there was a problem opening the Firefox browser.

Error: could not find CRI target
    at lazyAssLogic (/home/runner/.cache/Cypress/9.5.4/Cypress/resources/app/node_modules/lazy-ass/index.js:110:14)
    at lazyAss (/home/runner/.cache/Cypress/9.5.4/Cypress/resources/app/node_modules/lazy-ass/index.js:115:28)
    at findStartPage (/home/runner/.cache/Cypress/9.5.4/Cypress/resources/app/packages/server/lib/browsers/protocol.js:56:28)
    at runMicrotasks (<anonymous>:null:null)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

by switching these workflows to run with Chrome instead.

Also renames these jobs since tests is used in multiple workflows and these should ideally be unique.

Category

Test fix

Issues Resolved

• [Flaky CI] Intermittent failures with Cypress #1599

Check List

• New functionality includes testing
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (780b3aa) 67.09% compared to head (9514b39) 67.09%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1728   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files          94       94           
  Lines        2404     2404           
  Branches      318      318           
=======================================
  Hits         1613     1613           
  Misses        713      713           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[peternied]

@cwperks Could you create a copy of this PR in your fork with 10x runs of these jobs to make sure they are reliable then link it back here?

[cwperks]

@peternied I just pushed a branch to run this 10x

[cwperks]

@peternied See results of the run here: https://github.com/cwperks/security-dashboards-plugin/actions/runs/7448743565/job/20263781185

Ubuntu appears stable, but the windows runners do not consistently pass (its a coin toss).

Should I remove windows-latest from the matrix for these checks and file an issue around enabling these 2 checks on Windows?

[peternied]

Should I remove windows-latest from the matrix for these checks and file an issue around enabling these 2 checks on Windows?

Definitely, lets create a separate issue, or add onto an existing one to track what isn't working with windows.

[cwperks]

Thank you @peternied. I removed windows-latest from the matrix and will modify the description of this issue to include the 2 workflows in this PR.

[derek-ho]

LGTM