Fixes issue with expiryTime of OIDC cookie that causes refreshToken workflow to be skipped #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alankarsharma <[email protected]>
Signed-off-by: Alankarsharma <[email protected]>
Signed-off-by: Alankarsharma <[email protected]>
Signed-off-by: Alankarsharma <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
cliu123,
DarshitChanpura,
derek-ho,
RyanL1997 and
stephen-crawford
as code owners
Signed-off-by: Craig Perkins <[email protected]>
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1990 +/- ##
=======================================
Coverage 70.61% 70.61%
=======================================
Files 97 97
Lines 2600 2600
Branches 380 380
=======================================
Hits 1836 1836
Misses 668 668
Partials 96 96 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Craig Perkins <[email protected]>
derek-ho
reviewed
Jun 10, 2024
Signed-off-by: Craig Perkins <[email protected]>
derek-ho
approved these changes
Jun 11, 2024
stephen-crawford
approved these changes
Jun 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
…orkflow to be skipped (#1990) * Bug fix Signed-off-by: Alankarsharma <[email protected]> * Update cookie expiry as well Signed-off-by: Alankarsharma <[email protected]> * Lint issue fix Signed-off-by: Alankarsharma <[email protected]> * fixed test case Signed-off-by: Alankarsharma <[email protected]> * Add test for refresh token workflow in OIDC Signed-off-by: Craig Perkins <[email protected]> * Fix assertion Signed-off-by: Craig Perkins <[email protected]> * Update getKeepAliveExpiry logic for OIDC Signed-off-by: Craig Perkins <[email protected]> * Add check to ensure mockClient.post is called Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Alankarsharma <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Alankarsharma <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> (cherry picked from commit 70f2a9c)
cwperks
added a commit
that referenced
this pull request
Jun 11, 2024
…orkflow to be skipped (#1990) (#1995) * Bug fix Signed-off-by: Alankarsharma <[email protected]> * Update cookie expiry as well Signed-off-by: Alankarsharma <[email protected]> * Lint issue fix Signed-off-by: Alankarsharma <[email protected]> * fixed test case Signed-off-by: Alankarsharma <[email protected]> * Add test for refresh token workflow in OIDC Signed-off-by: Craig Perkins <[email protected]> * Fix assertion Signed-off-by: Craig Perkins <[email protected]> * Update getKeepAliveExpiry logic for OIDC Signed-off-by: Craig Perkins <[email protected]> * Add check to ensure mockClient.post is called Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Alankarsharma <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Alankarsharma <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> (cherry picked from commit 70f2a9c) Co-authored-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I branched off of the PR submitted by @Alankarsharma and added a unit test that verifies the OIDC refresh token flow.
This also updates one more area where the expiryTime is computed after a token refresh where it gets the new expiry time of the credentials (access token) from the refreshToken response's idToken.
Category
Bug fix
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.