Change JDK to 21 for main branch #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
RyanL1997 and
stephen-crawford
as code owners
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2008 +/- ##
=======================================
Coverage 70.61% 70.61%
=======================================
Files 97 97
Lines 2600 2600
Branches 380 380
=======================================
Hits 1836 1836
Misses 668 668
Partials 96 96 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <[email protected]>
stephen-crawford
previously approved these changes
Jun 17, 2024
RyanL1997
previously approved these changes
Jun 17, 2024
Signed-off-by: Derek Ho <[email protected]>
derek-ho
dismissed stale reviews from RyanL1997, stephen-crawford, and DarshitChanpura
via
0709fde
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
DarshitChanpura
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Thanks for working on the fix @derek-ho. This was an interesting CI fix :D
cwperks
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump JDK version to 21. Remove unnecessary steps in the CI.
Category
Maintenance
Why these changes are required?
Fix: #2009
What is the old behavior before changes and new behavior after changes?
Fix: #2009
Issues Resolved
Fix: #2009
Testing
Existing tests pass
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.