-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] [Feature] Introduces resource sharing and access-control #4746
base: feature/resource-permissions
Are you sure you want to change the base?
[DRAFT] [Feature] Introduces resource sharing and access-control #4746
Conversation
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
return services; | ||
} | ||
|
||
public static class GuiceHolder implements LifecycleComponent { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This GuiceHolder
pattern from the security plugin is IMHO only a hack to get access to dependencies which are available via dependency injection, but not via the createComponents()
API in the Plugin
interface. The un-hackish way to give plugins access to ResourceService
would be to add it to the param list of createComponents()
.
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Resource-sharing index gets created successfully upon first cluster start:
and subsequent starts show that the index is present:
Sample Resource Plugin loaded successfully:
|
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Moved sample resource plugin code to a separate PR: #4893 |
companion PR: opensearch-project/OpenSearch#16030
Description
Introduces a new authorization mechanism to control access to resources defined by plugins.
This PR also introduces a sample resource plugin to show the APIs in action.
Issues Resolved
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.