Add api token action to handle creation of api token index #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
cwperks,
DarshitChanpura,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
Signed-off-by: Derek Ho <[email protected]>
cwperks
reviewed
Nov 15, 2024
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
||
| import static org.opensearch.rest.RestRequest.Method.*; |
|
|
||
| public class ApiTokenApiAction extends AbstractApiAction { | ||
|
|
||
| public static final String NAME_JSON_PROPERTY = "ip"; |
There was a problem hiding this comment.
Looks like this is copied from elsewhere? Can this be removed?
|
|
||
| protected ApiTokenApiAction(ClusterService clusterService, ThreadPool threadPool, SecurityApiDependencies securityApiDependencies) { | ||
| super(Endpoint.APITOKENS, clusterService, threadPool, securityApiDependencies); | ||
| this.requestHandlersBuilder.configureRequestHandlers(this::authFailureConfigApiRequestHandlers); |
There was a problem hiding this comment.
nit: the naming also looks copied here. Can this be renamed?
| public void createApiTokenIndexIfAbsent(Client client) { | ||
| if (!apiTokenIndexExists()) { | ||
| final Map<String, Object> indexSettings = ImmutableMap.of("index.number_of_shards", 1, "index.auto_expand_replicas", "0-all"); | ||
| final CreateIndexRequest createIndexRequest = new CreateIndexRequest(ConfigConstants.OPENSEARCH_API_TOKENS_INDEX).settings(indexSettings); |
There was a problem hiding this comment.
FYI By subclassing AbstractApiAction this would be authorized like other security APIs. Like other API handlers, I think we will want to go to the transport layer here and execute a transport action and create the index from within there.
Any calls to a system index should be wrapped into threadContext.stashContext to assure that the plugin can perform the action regardless of the authenticated user's permissions.
Signed-off-by: Derek Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an API action to handle creation of API tokens index during PUT calls
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failedlabel from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.