Resolve Alias Issues in Legacy SQL with Filters

[aparajita31pandey]

Description

Alias query in legacy SQL which had filters to it didn't work . This diff addresses that issue. This diff derives index name from alias, for legacy sql queries having filters to it.

Before the change

curl -X POST "localhost:9200/_plugins/_sql" -H 'Content-Type: application/json' -d '{
  "query": "SELECT * FROM my-alias",
  "fetch_size": 1,
   "filter" : {
    "term" : {
      "field2" : "Sample keyword2"
    }
  }
}'
{
  "error": {
    "reason": "There was internal problem at backend",
    "details": "Index type [my-alias] does not exist",
    "type": "IllegalArgumentException"
  },
  "status": 500
}

After the change:

curl -X POST "localhost:9200/_plugins/_sql" -H 'Content-Type: application/json' -d '{
  "query": "SELECT * FROM my-alias",
  "fetch_size": 1,
   "filter" : {
    "term" : {
      "another_field" : "hello"
    }
  }
}'
{
  "schema": [
    {
      "name": "new_field",
      "type": "text"
    },
    {
      "name": "another_field",
      "type": "keyword"
    }
  ],
  "total": 1,
  "datarows": [[
    "Some text",
    "hello"
  ]],
  "size": 1,
  "status": 200

Related Issues

Resolves #2912
#1398 #1412

Check List

• New functionality includes testing.
• New functionality has been documented.
• New functionality has javadoc added.
• New functionality has a user manual doc added.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ctellechea2001]

@aparajita31pandey Do you know when could be this PR reviewed and merged to fix this issue that we have reported?
#2912

[HabooshHaddad]

Hello ,
Is this going to be merged anytime soon ?

[LantaoJin]

Thanks for your contribution, @aparajita31pandey could you add an IntegTest for the changes?
You can add an override method makeRequest for your test, ref

sql/integ-test/src/test/java/org/opensearch/sql/legacy/SQLIntegTestCase.java

Line 461 in c1e623d

protected String makeRequest(String query, int fetch_size) {

[aparajita31pandey]

@LantaoJin I have tested and added an IntegTest for the changes. Please take a look

[LantaoJin]

@aparajita31pandey please fix the code style problem via run ./gradlew spotlessApply

[aparajita31pandey]

@LantaoJin Updated the diff with ./gradlew spotlessApply

[LantaoJin]

The build failure is irrelevant, LGTM

[aparajita31pandey]

@dai-chen @ykmr1224 @MaxKsyunz Can I get one more approval please?

[MaxKsyunz]

LGTM

[aparajita31pandey]

Hey @LantaoJin , can you please help getting this diff merged ?

[ctellechea2001]

@LantaoJin Do you know in which open-search release version will be included? Thanks a lot!.