Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage issue for #3063 #3155

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Nov 14, 2024

Description

  • Fix coverage issue for Fix: CSV and Raw output, escape quotes #3063
  • cell parameter in quoteIfRequired won't be null since:
    • getOriginalData method convert null value to ""
    • getOriginalHeaders method does not accept null column value when adding to ImmutableList

Related Issues

n/a

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@Swiddis Swiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're picky enough we could argue for a @NonNull annotation on cell, but it's fine, LGTM

@ykmr1224 ykmr1224 merged commit 95a1643 into opensearch-project:main Nov 14, 2024
14 of 15 checks passed
@ykmr1224 ykmr1224 added backport 2.x maintenance Improves code quality, but not the product labels Nov 14, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-3155-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 95a16436a43ae474ca06aa1011081e3f3fc62ee9
# Push it to GitHub
git push --set-upstream origin backport/backport-3155-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3155-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 14, 2024
Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit 95a1643)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224 pushed a commit that referenced this pull request Nov 14, 2024
(cherry picked from commit 95a1643)

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x maintenance Improves code quality, but not the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants