Implement ppl join command with Calcite #3364
Merged
+1,872
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224 and
noCharger
as code owners
7 tasks
penghuo
approved these changes
Feb 28, 2025
| if (ctx.joinCriteria() == null) { | ||
| joinType = Join.JoinType.CROSS; | ||
| } | ||
| Join.JoinHint joinHint = getJoinHint(ctx.joinHintList()); |
There was a problem hiding this comment.
Do we have test cases on join hint? Curious if our hint is compatible with calcite's.
There was a problem hiding this comment.
JoinHint currently not in use in Spark-PPL, so it not in use in Calcite as well. I think we don't need to add any behaviours which Spark-PPL doesn't have for now. Will enable JoinHint when we completed Calcite integration job.
LantaoJin
merged commit f18c187
into
opensearch-project:feature/calcite-engine
6 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Core Syntax: Implement ppl join command with Calcite
./gradlew :integ-test:integTest --tests '*Calcite*IT'succeed in localRelated Issues
Resolves #3356
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.