-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-16077: fix base domain name validation #2268
OCPBUGS-16077: fix base domain name validation #2268
Conversation
@ammont82: This pull request references Jira Issue OCPBUGS-16077, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ammont82: This pull request references Jira Issue OCPBUGS-16077, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please rebase |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82, jgyselov, jkilzi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
@ammont82: Jira Issue OCPBUGS-16077 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Using same regex for base domain and dns domain that BE * Add unit tests for validate base domain name
Related to https://issues.redhat.com/browse/OCPBUGS-16077
Related to https://issues.redhat.com/browse/MGMT-15619
We need to align our regexp for base domain name validations with BE (openshift/assisted-service#5371 (comment)).
New regexps:
Before changes:
After changes: