Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Fixes a flaky test #2270

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

jkilzi
Copy link
Collaborator

@jkilzi jkilzi commented Jul 20, 2023

See: https://github.com/openshift-assisted/assisted-installer-ui/actions/runs/5609583925/job/15197510196?pr=2269
Fixes test-case: "Selecting external partner integrations checkbox enables custom manifests as well"
Reporting: "AssertionError: Timed out retrying after 4000ms: expected '<input#form-input-addCustomManifest-field.pf-c-check__input>' to be 'checked'"

@jkilzi jkilzi requested a review from a team as a code owner July 20, 2023 19:57
@openshift-ci-robot
Copy link

@jkilzi: This pull request explicitly references no jira issue.

In response to this:

See: https://github.com/openshift-assisted/assisted-installer-ui/actions/runs/5609583925/job/15197510196?pr=2269
Fixes test-case: "Selecting external partner integrations checkbox enables custom manifests as well"
Reporting: "AssertionError: Timed out retrying after 4000ms: expected '<input#form-input-addCustomManifest-field.pf-c-check__input>' to be 'checked'"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 20, 2023
@jkilzi jkilzi requested review from ammont82 and jgyselov July 20, 2023 19:57
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 20, 2023
Fixes test-case: "Selecting external partner integrations checkbox enables custom manifests as well"
Reporting: "AssertionError: Timed out retrying after 4000ms: expected '<input#form-input-addCustomManifest-field.pf-c-check__input>' to be 'checked'"
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgyselov jgyselov merged commit e8b195b into openshift-assisted:master Jul 21, 2023
8 checks passed
@jkilzi jkilzi deleted the task/fix-ci branch July 23, 2023 06:18
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
Fixes test-case: "Selecting external partner integrations checkbox enables custom manifests as well"
Reporting: "AssertionError: Timed out retrying after 4000ms: expected '<input#form-input-addCustomManifest-field.pf-c-check__input>' to be 'checked'"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants