Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-15330: Make the custom manifest YAML editor read-only #2273

Merged
merged 2 commits into from
Jul 25, 2023
Merged

MGMT-15330: Make the custom manifest YAML editor read-only #2273

merged 2 commits into from
Jul 25, 2023

Conversation

jgyselov
Copy link
Collaborator

@jgyselov jgyselov requested a review from a team as a code owner July 25, 2023 09:54
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 25, 2023 •
edited by openshift-ci bot
Loading

@jgyselov: This pull request references MGMT-15330 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/MGMT-15330

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2023
@jgyselov jgyselov requested review from ammont82 and jkilzi July 25, 2023 10:12
@jgyselov jgyselov added this to the v2.24 milestone Jul 25, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@ammont82
Copy link
Contributor

@jgyselov these changes don't affect tests for yaml's upload?

@jgyselov
Copy link
Collaborator Author

@jgyselov these changes don't affect tests for yaml's upload?

If it did, the test wouldn't pass without changes. (We are using the upload function in the tests, we are not typing the YAMLs manually.)

@ammont82
Copy link
Contributor

@jgyselov these changes don't affect tests for yaml's upload?

If it did, the test wouldn't pass without changes. (We are using the upload function in the tests, we are not typing the YAMLs manually.)

Perfect. Sorry, I wrote my comment before all tests passed. Good job

@jgyselov
Copy link
Collaborator Author

Perfect. Sorry, I wrote my comment before all tests passed.

I usually run the tests locally before I push to GH. So in case they fail, I can properly look into it right away. 🙂

@jgyselov jgyselov added the OCM label Jul 25, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkilzi
Copy link
Collaborator

jkilzi commented Jul 25, 2023

@talhil-rh FYI

@jkilzi jkilzi merged commit 62ccc6d into openshift-assisted:master Jul 25, 2023
8 checks passed
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
@jgyselov @jkilzi @rawagner
Make custom manifest code editor read-only (openshift-assisted#2273)
86a1e16 
Co-authored-by: Jonathan Kilzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkilzi jkilzi jkilzi approved these changes

@ammont82 ammont82 ammont82 approved these changes

Assignees

@ammont82 ammont82

@jkilzi jkilzi

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OCM size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v2.24
Development

Successfully merging this pull request may close these issues.
4 participants
@jgyselov @openshift-ci-robot @ammont82 @jkilzi