MGMT-15332: Adding same name for 2 manifests - UI shows error on all manifests #2278
Conversation
|
@jgyselov: This pull request references MGMT-15332 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
size/L
|
@jgyselov: This pull request references MGMT-15332 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jgyselov
force-pushed
the
custom_manifests_validation
branch
from
28471c9
to
e362b9a
Compare
|
@jkilzi PTAL especially at the tests. Personally, I'm happy with the structure but not quite so sure about using the aliases. |
...s/clusterConfiguration/manifestsConfiguration/components/customManifestsValidationSchema.tsx
Outdated
Show resolved
Hide resolved
jgyselov
force-pushed
the
custom_manifests_validation
branch
from
e362b9a
to
af3407f
Compare
jgyselov
force-pushed
the
custom_manifests_validation
branch
from
af3407f
to
e83d988
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82, jgyselov, jkilzi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
…manifests (openshift-assisted#2278) * Custom manifests filename validation * Custom manifests filename validation tests --------- Co-authored-by: Jonathan Kilzi <[email protected]>
https://issues.redhat.com/browse/MGMT-15332
In both screenshots, the manifests were called
manifest1.yaml,manifest2.yaml, andmanifest2.yaml.Before:
After: