Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15528: Use labels if status lacks OCP version #2288

Merged

Conversation

mareklibra
Copy link
Contributor

Just a fallback to another source of information.

Just a fallback to another source of information.
@mareklibra mareklibra requested a review from a team as a code owner August 11, 2023 11:01
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 11, 2023

@mareklibra: This pull request references MGMT-15528 which is a valid jira issue.

In response to this:

Just a fallback to another source of information.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 11, 2023
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 11, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jkilzi, mareklibra

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkilzi jkilzi merged commit 1837a8a into openshift-assisted:master Aug 24, 2023
7 checks passed
jgyselov pushed a commit to jgyselov/assisted-installer-ui that referenced this pull request Aug 24, 2023
…d#2288)

Just a fallback to another source of information.

Co-authored-by: Jonathan Kilzi <[email protected]>
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
…d#2288)

Just a fallback to another source of information.

Co-authored-by: Jonathan Kilzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants