Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15251: Link to infra env page instead of networking in case of n… #2289

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

rawagner
Copy link
Contributor

…tp failure

@rawagner rawagner requested a review from a team as a code owner August 12, 2023 14:21
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 12, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 12, 2023

@rawagner: This pull request references MGMT-15251 which is a valid jira issue.

In response to this:

…tp failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 12, 2023
ammont82
ammont82 previously approved these changes Aug 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@jkilzi jkilzi requested a review from ammont82 August 24, 2023 08:22
@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jkilzi, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkilzi jkilzi force-pushed the master branch 7 times, most recently from 745700c to 203646c Compare August 24, 2023 21:54
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

New changes are detected. LGTM label has been removed.

@jkilzi jkilzi merged commit 4f2bb70 into openshift-assisted:master Sep 7, 2023
7 checks passed
rawagner added a commit to rawagner/facet-lib that referenced this pull request Sep 13, 2023
openshift-assisted#2289)

* MGMT-15251: Link to infra env page instead of networking in case of ntp failure

* Update libs/ui-lib/lib/cim/components/ClusterDeployment/wizardTransition.ts

---------

Co-authored-by: Jonathan Kilzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants