Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19152: Add network bonding configuration in the UI #2683

Conversation

ammont82
Copy link
Contributor

Related to https://issues.redhat.com/browse/MGMT-19152

Users should be able to add a bond per host through the UI - "Form view" in the "Static network configurations > Host specific configurations" step.

How it works:

configuring_bonds.mp4

@ammont82 ammont82 added the OCM label Oct 23, 2024
@ammont82 ammont82 added this to the v2.36 milestone Oct 23, 2024
@ammont82 ammont82 requested a review from a team as a code owner October 23, 2024 14:16
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2024

@ammont82: This pull request references MGMT-19152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-19152

Users should be able to add a bond per host through the UI - "Form view" in the "Static network configurations > Host specific configurations" step.

How it works:

configuring_bonds.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2024

@ammont82: This pull request references MGMT-19152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-19152

Users should be able to add a bond per host through the UI - "Form view" in the "Static network configurations > Host specific configurations" step.

How it works:

configuring_bonds.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ammont82 ammont82 force-pushed the MGMT-18544-network-bonding-configuration-in-UI branch from 25b27d8 to 84781cf Compare October 24, 2024 05:26
@ammont82 ammont82 force-pushed the MGMT-18544-network-bonding-configuration-in-UI branch from 84781cf to 8d02d1f Compare October 24, 2024 06:01
@ammont82 ammont82 force-pushed the MGMT-18544-network-bonding-configuration-in-UI branch 2 times, most recently from 2dc5b59 to 09e0a1b Compare October 30, 2024 10:43
@ammont82 ammont82 force-pushed the MGMT-18544-network-bonding-configuration-in-UI branch from 09e0a1b to 55389ec Compare October 30, 2024 11:23
Copy link
Collaborator

@jgyselov jgyselov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And one more thing to address:

image

In the collapsed host view, there is a label mapping the MAC address to the IP address. With the new changes, there are two issues now when using bonds:

  1. user didn't specify MAC address, the label displays as above, it looks like an error
  2. user did specify the MAC address before checking "Use bonds", the label looks fine but the value there is not supposed to be there anymore (the user cannot see this field anymore)

When switching to using bonds, it might be worth deleting the original MAC address value.

When using bonds, these labels in the collapsed view might need to show different information.

@ammont82
Copy link
Contributor Author

ammont82 commented Nov 6, 2024

And one more thing to address:

image

In the collapsed host view, there is a label mapping the MAC address to the IP address. With the new changes, there are two issues now when using bonds:

  1. user didn't specify MAC address, the label displays as above, it looks like an error
  2. user did specify the MAC address before checking "Use bonds", the label looks fine but the value there is not supposed to be there anymore (the user cannot see this field anymore)

When switching to using bonds, it might be worth deleting the original MAC address value.

When using bonds, these labels in the collapsed view might need to show different information.

@jgyselov I've implemented these changes:

  • Collapsed view host when MAC Address is selected without bonds:
    image

  • Collapsed view host when bond are selected:
    image

@ammont82 ammont82 force-pushed the MGMT-18544-network-bonding-configuration-in-UI branch from 520e99b to 0a81f5a Compare November 6, 2024 10:18
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2024
Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit b7f8a32 into openshift-assisted:master Nov 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OCM size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants