-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-19152: Add network bonding configuration in the UI #2683
MGMT-19152: Add network bonding configuration in the UI #2683
Conversation
@ammont82: This pull request references MGMT-19152 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ammont82: This pull request references MGMT-19152 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
25b27d8
to
84781cf
Compare
84781cf
to
8d02d1f
Compare
libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/staticIp.css
Outdated
Show resolved
Hide resolved
...ib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewHosts/BondsSelect.tsx
Outdated
Show resolved
Hide resolved
libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/staticIp.css
Outdated
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx
Outdated
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx
Outdated
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx
Outdated
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx
Outdated
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx
Outdated
Show resolved
Hide resolved
...nts/clusterConfiguration/staticIp/components/FormViewHosts/formViewHostsValidationSchema.tsx
Outdated
Show resolved
Hide resolved
libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/data/formDataFromInfraEnvField.ts
Outdated
Show resolved
Hide resolved
...nts/clusterConfiguration/staticIp/components/FormViewHosts/formViewHostsValidationSchema.tsx
Outdated
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx
Outdated
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx
Outdated
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx
Outdated
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx
Outdated
Show resolved
Hide resolved
...components/clusterConfiguration/staticIp/components/FormViewHosts/BondsConfirmationModal.tsx
Outdated
Show resolved
Hide resolved
...ib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewHosts/BondsSelect.tsx
Show resolved
Hide resolved
...ib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewHosts/BondsSelect.tsx
Outdated
Show resolved
Hide resolved
2dc5b59
to
09e0a1b
Compare
09e0a1b
to
55389ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And one more thing to address:
In the collapsed host view, there is a label mapping the MAC address to the IP address. With the new changes, there are two issues now when using bonds:
- user didn't specify MAC address, the label displays as above, it looks like an error
- user did specify the MAC address before checking "Use bonds", the label looks fine but the value there is not supposed to be there anymore (the user cannot see this field anymore)
When switching to using bonds, it might be worth deleting the original MAC address value.
When using bonds, these labels in the collapsed view might need to show different information.
...nts/clusterConfiguration/staticIp/components/FormViewHosts/formViewHostsValidationSchema.tsx
Outdated
Show resolved
Hide resolved
@jgyselov I've implemented these changes: |
520e99b
to
0a81f5a
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82, jgyselov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to https://issues.redhat.com/browse/MGMT-19152
Users should be able to add a bond per host through the UI - "Form view" in the "Static network configurations > Host specific configurations" step.
How it works:
configuring_bonds.mp4