Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ART-7409] Update gen-assembly tekton job for ART OSD #3862

Merged
merged 1 commit into from
Aug 29, 2023
Merged

[ART-7409] Update gen-assembly tekton job for ART OSD #3862

merged 1 commit into from
Aug 29, 2023

Conversation

vfreex
Copy link
Contributor

@vfreex vfreex commented Aug 4, 2023 •
edited
Loading

  • Bump base image and dependencies for artcd image
  • Update gen-assembly job to use pyartcd
  • Add externalsecrets for secrets managed on AWS Secrets Manager

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@vfreex vfreex changed the title WIP - Tekton pipeline migration WIP - migrate gen-assembly to OSD Aug 9, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2023
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@vfreex vfreex changed the title WIP - migrate gen-assembly to OSD [ART-7409] Update gen-assembly tekton job for ART OSD Aug 11, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2023
@ashwindasr
Copy link
Contributor

Tried to test it but my pod wouldn't spawn 0/7 nodes are available: 2 Insufficient cpu, 2 node(s) had untolerated taint {node-role.kubernetes.io/infra: }, 3 node(s) had untolerated taint {node-role.kubernetes.io/master: }. preemption: 0/7 nodes are available: 2 No preemption victims found for incoming pod, 5 Preemption is not helpful for scheduling.

@ashwindasr
Copy link
Contributor

Looks like the dynamic scaling worked, the pod threw the same error but I waited for a couple of minutes and the pod was spawned. Testing

@ashwindasr ashwindasr mentioned this pull request Aug 22, 2023
Closed
@ashwindasr
Copy link
Contributor

The auto PR that gets created says created by job run None we can maybe add a link to the pipeline run URL? I think we should be able to get some values from the ENV variables.

@ashwindasr
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ashwindasr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vfreex
Update gen-assembly tekton job for ART OSD
914e684 
- Bump base image and dependencies for artcd image
- Update gen-assembly job to use pyartcd
- Add externalsecrets for secrets managed on AWS Secrets Manager
@vfreex vfreex merged commit 9fd13e4 into openshift-eng:master Aug 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ashwindasr ashwindasr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vfreex @ashwindasr