[konflux] add assembly type to app name, component name #1105
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| app_name = self._config.group_name.replace(".", "-") | ||
| group_name = self._config.group_name.replace(".", "-") | ||
| app_name = group_name | ||
| app_name = f"{app_name}-{metadata.runtime.assembly}" |
There was a problem hiding this comment.
I'm using the group name below: https://github.com/openshift-eng/art-tools/pull/1105/files#diff-e45d70130344e3d45bd59cb091bd0a794121c675ce90f17c5b4e4702ded620ffR183
So didn't want to replace the . with - again
| component_name = f"{app_name}-{metadata.distgit_key}".replace(".", "-").replace("_", "-") | ||
| # Since Component is a CRD, it has to be unique in the namespace. Also once a Component and Application is created, the branches that its linked to cannot be modified | ||
| # Hence prefixing the assembly and version to the component name to make it unique, eg: "stream-4-18-ose-etcd" | ||
| component_name = f"{metadata.runtime.assembly}-{group_name.removeprefix(f'openshift-')}-{metadata.distgit_key}".replace(".", "-").replace("_", "-") |
There was a problem hiding this comment.
rather than computing something from distgit-key, can we have the konflux name entity hard coded rather than calculated through an attribute in ocp-build-data?
ashwindasr
force-pushed
the
konflux-app-name-update
branch
from
7635ead
to
50c127b
Compare
|
@ashwindasr: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ashwindasr
added
the
do-not-merge/hold
|
We might need to ship a release coming from mixed assemblies (e.g. stream and 4.y.z). I am not sure if it will be an issue if we separate assemblies and components by assembly name. Do you have any other reason (except shortening resource names) to make this change? Also it guess it might be fine to just truncate the distgit keys in some way or having a new field as suggested by @joepvd . What do you think? |
|
Yeah this change makes me weary a little bit.. we have to do a good amount of config admin work with application names / component names in konflux-release-dev repo for releases. So why exactly are we doing this? or what is the problem right now that this would solve? |
When we tried to trigger
streambuilds, openshift did not let us update theComponentsince it was tied to atestGH branch. Hence we want to separateApplicationandComponentCRDs based on version and assembly and names have to be unique in a namespace.So an application from now on will look like
openshift-4-18-stream/openshift-4-18-testand a component will look likestream-4-18-ose-etcd/test-4-18-ose-etcdAlso since Kubernetes resources have a maximum character length of 63 characters, lets no onboard a component with very long distgit names.