Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At GA time, we determine which flaw bugs are first fixes and only attach those to advisories.
But this analysis is quite heavy, each flaw bug can take upto half a minute or more and there
are 50+ flaw bugs to analyze at GA time. So this can mean 30+ minutes to determine first fixes.
This means the commands
attach-cve-flaws
andverify-attached-bugs --verify-flaws
both areessentially blocked on this, they cannot proceed with the other things that they do before this
analysis completes.
In addition to that http requests can fail/timeout, which can cause the command to fail and be
brittle. So in this proposal, we can capture the list of cves that are determined to be first fixes in
the first proper run (30+ mins) and then in subsequent runs we can provide the command with
this list to speedup. Essentially a cache. We can think about capturing this in assembly definition
or redis. One more todo is to look at the http requests we are making and caching them and see
if there is a significant speedup due to duplicate requests.