Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP First fix speedup #723

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thegreyd
Copy link
Contributor

@thegreyd thegreyd commented Jun 25, 2024

At GA time, we determine which flaw bugs are first fixes and only attach those to advisories.
But this analysis is quite heavy, each flaw bug can take upto half a minute or more and there
are 50+ flaw bugs to analyze at GA time. So this can mean 30+ minutes to determine first fixes.

This means the commands attach-cve-flaws and verify-attached-bugs --verify-flaws both are
essentially blocked on this, they cannot proceed with the other things that they do before this
analysis completes.

In addition to that http requests can fail/timeout, which can cause the command to fail and be
brittle. So in this proposal, we can capture the list of cves that are determined to be first fixes in
the first proper run (30+ mins) and then in subsequent runs we can provide the command with
this list to speedup. Essentially a cache. We can think about capturing this in assembly definition
or redis. One more todo is to look at the http requests we are making and caching them and see
if there is a significant speedup due to duplicate requests.

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from thegreyd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

@thegreyd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security ebb9c39 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thegreyd thegreyd changed the title First fix speedup WIP First fix speedup Jun 25, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants