Remove unnecessary 'go get' commands

Signed-off-by: Matej Vašek <[email protected]>
openshift-knative · Sep 27, 2024 · 74e90d9 · 74e90d9
1 parent ad0b694
commit 74e90d9
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 22 deletions.
diff --git a/pkg/builders/s2i/assemblers.go b/pkg/builders/s2i/assemblers.go
@@ -49,7 +49,6 @@ if [[ $(go list -f {{.Incomplete}}) == "true" ]]; then
     exec /$STI_SCRIPTS_PATH/usage
 else
     pushd .s2i/builds/last
-    go get f
     go build -o /opt/app-root/gobinary
     popd
     popd

diff --git a/pkg/functions/runner.go b/pkg/functions/runner.go
@@ -110,21 +110,12 @@ func runGo(ctx context.Context, job *Job) (err error) {
 		fmt.Printf("cd %v && go build -o f.bin\n", job.Dir())
 	}
 
-	// Get the dependencies of the function
-	cmd := exec.CommandContext(ctx, "go", "get", "f")
-	cmd.Dir = job.Dir()
-	cmd.Stderr = os.Stderr
-	cmd.Stdout = os.Stdout
-	if err = cmd.Run(); err != nil {
-		return
-	}
-
 	// Build
 	args := []string{"build", "-o", "f.bin"}
 	if job.verbose {
 		args = append(args, "-v")
 	}
-	cmd = exec.CommandContext(ctx, "go", args...)
+	cmd := exec.CommandContext(ctx, "go", args...)
 	cmd.Dir = job.Dir()
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr

diff --git a/pkg/oci/containerize_go.go b/pkg/oci/containerize_go.go
@@ -65,18 +65,8 @@ func goBuild(cfg *buildConfig, p v1.Platform) (binPath string, err error) {
 		fmt.Printf("   %v\n", filepath.Base(outpath))
 	}
 
-	// Get the dependencies of the function
-	cmd := exec.CommandContext(cfg.ctx, gobin, "get", "f")
-	cmd.Env = envs
-	cmd.Dir = cfg.buildDir()
-	cmd.Stderr = os.Stderr
-	cmd.Stdout = os.Stdout
-	if err = cmd.Run(); err != nil {
-		return
-	}
-
 	// Build the function
-	cmd = exec.CommandContext(cfg.ctx, gobin, args...)
+	cmd := exec.CommandContext(cfg.ctx, gobin, args...)
 	cmd.Env = envs
 	cmd.Dir = cfg.buildDir()
 	cmd.Stderr = os.Stderr