fix: NPE (knative#2062)

Signed-off-by: Matej Vasek <[email protected]>
openshift-knative · Nov 1, 2023 · cf2fd0e · cf2fd0e
1 parent 9fbd7c9
commit cf2fd0e
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/pkg/knative/deployer.go b/pkg/knative/deployer.go
@@ -834,18 +834,21 @@ func processVolumes(volumes []fn.Volume, referencedSecrets, referencedConfigMaps
 
 			if !createdVolumes.Has(volumeName) {
 
-				sizeLimit, err := resource.ParseQuantity(*vol.EmptyDir.SizeLimit)
-
-				if err != nil {
-					return nil, nil, fmt.Errorf("invalid quantity for sizeLimit: %s. Error: %s", *vol.EmptyDir.SizeLimit, err)
+				var sizeLimit *resource.Quantity
+				if vol.EmptyDir.SizeLimit != nil {
+					sl, err := resource.ParseQuantity(*vol.EmptyDir.SizeLimit)
+					if err != nil {
+						return nil, nil, fmt.Errorf("invalid quantity for sizeLimit: %s. Error: %s", *vol.EmptyDir.SizeLimit, err)
+					}
+					sizeLimit = &sl
 				}
 
 				newVolumes = append(newVolumes, corev1.Volume{
 					Name: volumeName,
 					VolumeSource: corev1.VolumeSource{
 						EmptyDir: &corev1.EmptyDirVolumeSource{
 							Medium:    corev1.StorageMedium(vol.EmptyDir.Medium),
-							SizeLimit: &sizeLimit,
+							SizeLimit: sizeLimit,
 						},
 					},
 				})