-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serverless-1.30.0] patch func deploy task for serverless 1.30.0 #630
[serverless-1.30.0] patch func deploy task for serverless 1.30.0 #630
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## serverless-1.30 #630 +/- ##
==================================================
Coverage ? 61.13%
==================================================
Files ? 94
Lines ? 12169
Branches ? 0
==================================================
Hits ? 7439
Misses ? 4065
Partials ? 665
Flags with carried forward coverage won't be shown. Click here to find out more. |
@jrangelramos shouldn't this be also applied to pac version of the file? |
/hold |
fa398b8
to
34b5700
Compare
… image (2nd build)
/override "On Cluster RT Test (1.20.x, ubuntu-latest)" |
@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override "On Cluster RT Test (1.20.5, ubuntu-latest)" |
@matejvasek: Overrode contexts on behalf of matejvasek: On Cluster RT Test (1.20.5, ubuntu-latest), On Cluster Test (1.20.5, ubuntu-latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrangelramos, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unhold |
d29f307
into
openshift-knative:serverless-1.30
patch for func-deploy task to use midstream specific client built for 1.30.0