Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.30.0] patch func deploy task for serverless 1.30.0 #630

Conversation

jrangelramos
Copy link

patch for func-deploy task to use midstream specific client built for 1.30.0

@openshift-ci openshift-ci bot requested review from nainaz and rhuss August 10, 2023 17:59
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (serverless-1.30@905e631). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                Coverage Diff                 @@
##             serverless-1.30     #630   +/-   ##
==================================================
  Coverage                   ?   61.13%           
==================================================
  Files                      ?       94           
  Lines                      ?    12169           
  Branches                   ?        0           
==================================================
  Hits                       ?     7439           
  Misses                     ?     4065           
  Partials                   ?      665           
Flag Coverage Δ
e2e-test 39.56% <0.00%> (?)
e2e-test-runtime-go 28.03% <0.00%> (?)
e2e-test-runtime-node 29.15% <0.00%> (?)
e2e-test-runtime-springboot 28.19% <0.00%> (?)
integration-tests 50.05% <0.00%> (?)
unit-tests-macos-latest 48.35% <0.00%> (?)
unit-tests-ubuntu-latest 49.23% <0.00%> (?)
unit-tests-windows-latest 48.40% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@matejvasek matejvasek changed the base branch from serverless-1.30.0 to serverless-1.30 August 23, 2023 16:44
@matejvasek
Copy link
Collaborator

@jrangelramos shouldn't this be also applied to pac version of the file?

@matejvasek matejvasek requested review from dsimansk and matejvasek and removed request for rhuss and nainaz August 23, 2023 17:44
@jrangelramos
Copy link
Author

/hold

@jrangelramos jrangelramos force-pushed the patch/func-deploy-task-serverless-v1.30.0 branch from fa398b8 to 34b5700 Compare August 24, 2023 13:27
@matejvasek
Copy link
Collaborator

/override "On Cluster RT Test (1.20.x, ubuntu-latest)"
/override "On Cluster Test (1.20.x, ubuntu-latest)"

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • On Cluster RT Test (1.20.x, ubuntu-latest)
  • On Cluster Test (1.20.x, ubuntu-latest)

Only the following failed contexts/checkruns were expected:

  • E2E Test (python)
  • E2E Test (quarkus)
  • E2E Test (typescript)
  • On Cluster RT Test (1.20.5, ubuntu-latest)
  • On Cluster Test (1.20.5, ubuntu-latest)
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "On Cluster RT Test (1.20.x, ubuntu-latest)"
/override "On Cluster Test (1.20.x, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Collaborator

/override "On Cluster RT Test (1.20.5, ubuntu-latest)"
/override "On Cluster Test (1.20.5, ubuntu-latest)"

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

@matejvasek: Overrode contexts on behalf of matejvasek: On Cluster RT Test (1.20.5, ubuntu-latest), On Cluster Test (1.20.5, ubuntu-latest)

In response to this:

/override "On Cluster RT Test (1.20.5, ubuntu-latest)"
/override "On Cluster Test (1.20.5, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Collaborator

/approve
/lgtm

@matejvasek
Copy link
Collaborator

/approve
/lgtm
/override "On Cluster RT Test (1.20.5, ubuntu-latest)"
/override "On Cluster Test (1.20.5, ubuntu-latest)"

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jrangelramos,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2023

@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • On Cluster RT Test (1.20.5, ubuntu-latest)
  • On Cluster Test (1.20.5, ubuntu-latest)

Only the following failed contexts/checkruns were expected:

  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/approve
/lgtm
/override "On Cluster RT Test (1.20.5, ubuntu-latest)"
/override "On Cluster Test (1.20.5, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Collaborator

/unhold

@openshift-merge-robot openshift-merge-robot merged commit d29f307 into openshift-knative:serverless-1.30 Sep 6, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants