Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.30.0] Patch tekton pipeline task reference #638

Conversation

jrangelramos
Copy link

Change required for Pipelines as Code to reference midstream repository

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #638 (094fc86) into serverless-1.30.0 (c4d667d) will increase coverage by 13.40%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                  Coverage Diff                   @@
##           serverless-1.30.0     #638       +/-   ##
======================================================
+ Coverage              49.66%   63.07%   +13.40%     
======================================================
  Files                     82       95       +13     
  Lines                  11253    12773     +1520     
======================================================
+ Hits                    5589     8056     +2467     
+ Misses                  5180     4053     -1127     
- Partials                 484      664      +180     
Flag Coverage Δ
e2e-test 39.86% <ø> (?)
e2e-test-runtime-go 27.17% <ø> (?)
e2e-test-runtime-node 29.37% <ø> (?)
e2e-test-runtime-python 29.37% <ø> (?)
e2e-test-runtime-quarkus 29.50% <ø> (?)
e2e-test-runtime-springboot 27.35% <ø> (?)
e2e-test-runtime-typescript 29.50% <ø> (?)
integration-tests 49.76% <ø> (?)
unit-tests-macos-latest 51.75% <ø> (?)
unit-tests-ubuntu-latest 52.59% <ø> (?)
unit-tests-windows-latest 48.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/pipelines/tekton/templates.go 72.32% <ø> (ø)

... and 59 files with indirect coverage changes

@jrangelramos
Copy link
Author

/hold

@matejvasek
Copy link
Collaborator

/approve
/lgtm

/hold for tests

@matejvasek
Copy link
Collaborator

@jrangelramos some of the tests are failing because of Go version.

@matejvasek
Copy link
Collaborator

@jrangelramos you need to downgrade Go to 1.20.5 in GH workflows.

@openshift-ci openshift-ci bot removed the lgtm label Aug 16, 2023
@matejvasek
Copy link
Collaborator

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Aug 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jrangelramos,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jrangelramos
Copy link
Author

/unhold

@matejvasek
Copy link
Collaborator

this might meed override

@matejvasek matejvasek merged commit f755270 into openshift-knative:serverless-1.30.0 Aug 17, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants