[serverless-1.30] fix: bad connection handling for in cluster dialer #647
Conversation
* fix: bad connection handling for in cluster dialer Connections were closed from wrong end of io.Pipe which resulted in confusing error logs. Signed-off-by: Matej Vasek <[email protected]> * feat: DialContext() better error handling Now DialContext() returns some errors immediately instead of deferring it Read/Write operation on the returned connection. Signed-off-by: Matej Vasek <[email protected]> * feat: DialContext() more better error handling Now ContextDial() tries to parse socat's stderr and translate it to Go's net.OpError instead of just creating error with whole stderr embedded in it. Signed-off-by: Matej Vasek <[email protected]> * Apply suggestions from code review Co-authored-by: Lance Ball <[email protected]> --------- Signed-off-by: Matej Vasek <[email protected]> Co-authored-by: Lance Ball <[email protected]>
matejvasek
requested review from
dsimansk and
jrangelramos
and removed request for
nainaz and
vyasgun
|
PTAL @jrangelramos |
Signed-off-by: Matej Vasek <[email protected]>
Signed-off-by: Matej Vasek <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## serverless-1.30 #647 +/- ##
==================================================
Coverage ? 63.26%
==================================================
Files ? 95
Lines ? 12859
Branches ? 0
==================================================
Hits ? 8135
Misses ? 4059
Partials ? 665
Flags with carried forward coverage won't be shown. Click here to find out more. |
matejvasek
changed the title
|
@dsimansk please check this is a compatible change |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override "On Cluster RT Test (1.20.5, ubuntu-latest)" |
|
@dsimansk: Overrode contexts on behalf of dsimansk: On Cluster RT Test (1.20.5, ubuntu-latest), On Cluster Test (1.20.5, ubuntu-latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
merged commit 8331fc8
into
openshift-knative:serverless-1.30
backport knative#1800
This makes
io: read/write on closed pipego away.