Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.33] patch func deploy task for serverless 1.33.0 #768

Conversation

serverless-qe
Copy link

patch for func-deploy task to use midstream specific client built for 1.33.0

Copy link

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: serverless-qe
Once this PR has been reviewed and has the lgtm label, please ask for approval from matejvasek. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.33.0 branch 2 times, most recently from 5df1119 to ed28493 Compare May 23, 2024 14:00
@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.33.0 branch 2 times, most recently from 27b0a20 to ccf8212 Compare May 30, 2024 19:50
@matejvasek
Copy link
Collaborator

@jrangelramos this has to be changed we use different image for deploys now

@jrangelramos
Copy link

@matejvasek yes. We got the automated scripts updated. This PR will be updated automatically on RC2.

@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.33.0 branch 4 times, most recently from 1bc219f to 0ae35bf Compare June 11, 2024 07:01
@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.33.0 branch from 0ae35bf to 236ca3e Compare June 17, 2024 22:38
@jrangelramos
Copy link

Merging since the images are already published and released.

@jrangelramos jrangelramos merged commit f9f4ecd into serverless-1.33 Jun 21, 2024
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants