-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v1.15] Fixes #926
Conversation
Some tools dislike having questionable symlinks in git repository so we must create this symlinks dynamically in the test instead of having it committed into the repository. Signed-off-by: Matej Vašek <[email protected]>
432c898
to
c8ff2c4
Compare
/test 416-unit |
/test kn-plugin-func-func-util-115-on-pull-request |
@matejvasek: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Matej Vašek <[email protected]>
Ensure that ServeRepo() make copy of repo from ./testdata and serves the repo from that copy. Signed-off-by: Matej Vašek <[email protected]> --------- Signed-off-by: Matej Vašek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cloned repository contains symlink pointing outside of the cloned repository: /workspace/output/source/pkg/oci/testdata/test-links/absoluteLink
seems to be fixed with this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixed konflux symlink error. Some tools dislike having questionable symlinks in git repository so we must create these symlinks dynamically in the test instead of having it committed into the repository.
Picked [serverless-1.34] Remove unnecessary annotations from Pipeline-as-Code template [SRVOCF-626] #917
Picked [serverless-1.34] Set default value for REGISTRY param on func-s2i task [SRVOCF-628] #922
Fixed socat rpm size/hash
Picked Fix test failures in OCP prow CI knative/func#2503