Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.15] Fixes #926

Merged
merged 5 commits into from
Oct 4, 2024
Merged

[release-v1.15] Fixes #926

merged 5 commits into from
Oct 4, 2024

Conversation

matejvasek
Copy link
Collaborator

@matejvasek matejvasek commented Oct 3, 2024

Some tools dislike having questionable symlinks in git repository so we
must create this symlinks dynamically in the test instead of having it
committed into the repository.

Signed-off-by: Matej Vašek <[email protected]>
@matejvasek matejvasek changed the title Create test symlinks dynamically [release-v1.15] Fixes Oct 3, 2024
@matejvasek
Copy link
Collaborator Author

/test 416-unit
/test 417-unit

@matejvasek
Copy link
Collaborator Author

/test kn-plugin-func-func-util-115-on-pull-request

Copy link

openshift-ci bot commented Oct 3, 2024

@matejvasek: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test 416-e2e-oncluster-test
  • /test 416-images
  • /test 416-unit
  • /test 417-e2e-oncluster-test
  • /test 417-images
  • /test 417-unit

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-knative-kn-plugin-func-release-v1.15-416-e2e-oncluster-test
  • pull-ci-openshift-knative-kn-plugin-func-release-v1.15-416-images
  • pull-ci-openshift-knative-kn-plugin-func-release-v1.15-416-unit
  • pull-ci-openshift-knative-kn-plugin-func-release-v1.15-417-e2e-oncluster-test
  • pull-ci-openshift-knative-kn-plugin-func-release-v1.15-417-unit

In response to this:

/test kn-plugin-func-func-util-115-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek
Copy link
Collaborator Author

PTAL @creydr @pierDipi

Ensure that ServeRepo() make copy of repo from ./testdata and serves the
repo from that copy.

Signed-off-by: Matej Vašek <[email protected]>

---------

Signed-off-by: Matej Vašek <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cloned repository contains symlink pointing outside of the cloned repository: /workspace/output/source/pkg/oci/testdata/test-links/absoluteLink

seems to be fixed with this PR

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 382b5e2 into release-v1.15 Oct 4, 2024
46 checks passed
@pierDipi pierDipi deleted the fixup-test-lns branch October 4, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants