Skip to content

Commit

Permalink
Do not skip TestTargetBurstCapacity when dataplane-trust is not spe…
Browse files Browse the repository at this point in the history
…cified (knative#14300) (#427)

* Do not skip TestTargetBurstCapacity when `dataplane-trust` is not specified

* use empty string

* Use dataplane-trust instead of internal-encryption

* Revert "Use dataplane-trust instead of internal-encryption"

This reverts commit 1acfacc.

* Add deprecated internal-encryption

* Fix
  • Loading branch information
nak3 authored Aug 29, 2023
1 parent d4c08cb commit 2aff92a
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions test/e2e/autoscale_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,11 @@ func TestTargetBurstCapacity(t *testing.T) {
if err != nil {
t.Fatal("Fail to get ConfigMap config-network:", err)
}
if !strings.EqualFold(cm.Data[netcfg.DataplaneTrustKey], string(netcfg.TrustDisabled)) {
// TODO: Remove this when https://github.com/knative/serving/issues/12797 was done.
t.Skip("Skipping TestTargetBurstCapacity as activator-ca is specified. See issue/12797.")

// TODO: Remove this when "activator always stay in path" is eliminated.
dataplaneTrustMode := cm.Data[netcfg.DataplaneTrustKey]
if (dataplaneTrustMode != "" && !strings.EqualFold(dataplaneTrustMode, string(netcfg.TrustDisabled))) || strings.EqualFold(cm.Data[netcfg.InternalEncryptionKey], "true") {
t.Skip("Skipping TestTargetBurstCapacity as activator always stay in path.")
}

cfg, err := autoscalerCM(ctx.clients)
Expand Down

0 comments on commit 2aff92a

Please sign in to comment.