Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version for builder image #1174

Merged

Conversation

skonto
Copy link

@skonto skonto commented Feb 7, 2025

What this PR does / why we need it:

@openshift-ci openshift-ci bot requested review from alanfx and mgencur February 7, 2025 12:21
@skonto
Copy link
Author

skonto commented Feb 7, 2025

/hold

@skonto skonto requested review from dsimansk and removed request for mgencur and alanfx February 7, 2025 12:21
@skonto
Copy link
Author

skonto commented Feb 7, 2025

/unhold

@skonto
Copy link
Author

skonto commented Feb 7, 2025

Probably need to run ./openshift/generate.sh

@skonto
Copy link
Author

skonto commented Feb 7, 2025

Not sure if it makes sense to update openshift/ci-operator/build-image manually as we dont have a go.mod file on main branch

@skonto
Copy link
Author

skonto commented Feb 7, 2025

Anyway I added a fake go.mod and generated it.

@dsimansk
Copy link

dsimansk commented Feb 7, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 7, 2025
Copy link

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link

dsimansk commented Feb 7, 2025

@skonto do we need it for release-next branch onwards?

@dsimansk
Copy link

dsimansk commented Feb 7, 2025

Not sure if it makes sense to update openshift/ci-operator/build-image manually as we dont have a go.mod file on main branch

Interesting, we don't have those validate GH actions on other components. Agreed it little sense.

@openshift-merge-bot openshift-merge-bot bot merged commit 8b8045b into openshift-knative:main Feb 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants