[SRVKS-1262] ContainerHealthy reset #838
Conversation
skonto
requested review from
maschmid
and removed request for
alanfx and
ReToCode
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4a9d614
into
openshift-knative:release-v1.14
| @@ -117,6 +117,9 @@ func (c *Reconciler) reconcileDeployment(ctx context.Context, rev *v1.Revision) | |||
| } | |||
| } | |||
|
|
|||
| if *deployment.Spec.Replicas > 0 && *deployment.Spec.Replicas == deployment.Status.ReadyReplicas { | |||
There was a problem hiding this comment.
Should it be compared to AvailableReplicas instead?
There was a problem hiding this comment.
@maschmid I had the same question. Afaik ready means available as we the deployment we create has the following set to 0:
// Minimum number of seconds for which a newly created pod should be ready
// without any of its container crashing, for it to be considered available.
// Defaults to 0 (pod will be considered available as soon as it is ready)
// +optional
MinReadySeconds int32 `json:"minReadySeconds,omitempty" protobuf:"varint,5,opt,name=minReadySeconds"`
|
/cherry-pick release-v1.15 |
|
@maschmid: new pull request created: #935 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-v1.16 |
|
@maschmid: new pull request created: #936 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-v1.16 |
|
@skonto: new pull request created: #944 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it: