added version check to test 54240 #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaskosk
reviewed
Jul 25, 2024
added 2 commits
July 25, 2024 17:40
klaskosk
approved these changes
Jul 25, 2024
kononovn
approved these changes
Jul 29, 2024
|
@josclark42 This ended up not needing a version check since the issue is autoindent being used with an integer argument, which causes an error (as desired) even in ZTP 4.16 and above. Just closing this now so it's not lingering but happy to revisit later if the situation changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 54240 requires ZTP 4.15 or less. Added a check to this test.