Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19292: align /var/lib/containers partition label with var-lib-containers #693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tsorya
Copy link
Contributor

@tsorya tsorya commented Nov 20, 2024

MGMT-19292: align /var/lib/containers partition label with var-lib-containers

In all ztp examples and docs we have var-lib-containers as label for containers partition, that's why we need to align with them

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

…ntainers

In all ztp examples and docs we have var-lib-containers as label for
containers partition, that's why we need to align with them
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2024

@tsorya: This pull request references MGMT-19292 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

MGMT-19292: align /var/lib/containers partition label with var-lib-containers

In all ztp examples and docs we have var-lib-containers as label for containers partition, that's why we need to align with them

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2024

@tsorya: This pull request references MGMT-19292 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

MGMT-19292: align /var/lib/containers partition label with var-lib-containers

In all ztp examples and docs we have var-lib-containers as label for containers partition, that's why we need to align with them

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tsorya
Copy link
Contributor Author

tsorya commented Nov 20, 2024

/hold till we agree that this is required and open doc tickets

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
Copy link
Collaborator

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2024
@eranco74
Copy link
Collaborator

/hold till we agree that this is required and open doc tickets

We have a doc ticket https://issues.redhat.com/browse/MGMT-19294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants