-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNF-14648: spec updates in the ClusterTemplate #219
CNF-14648: spec updates in the ClusterTemplate #219
Conversation
@edcdavid: This pull request references CNF-14648 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
@edcdavid: This pull request references CNF-14648 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@edcdavid: This pull request references CNF-14648 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
I think this will need to be updated:
The clusterInstanceSchema/policyTemplateSchema should be renamed to clusterInstanceParameters/policyTemplateParameters since they are no longer schemas on their own, but just sections in the templateParameterSchema. |
/hold |
7553f33
to
6469ebc
Compare
@edcdavid: This pull request references CNF-14648 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@edcdavid: This pull request references CNF-14648 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@edcdavid: This pull request references CNF-14648 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@edcdavid: This pull request references CNF-14648 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Please update the ClusterTemplate example in the PR description to reflect the updated naming. |
6469ebc
to
4ee1a9a
Compare
@edcdavid: This pull request references CNF-14648 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4ee1a9a
to
261959b
Compare
0512747
to
ea85d81
Compare
/unhold |
ca5ebd1
to
e06e164
Compare
26f0525
to
7c81b40
Compare
7c81b40
to
8d33e80
Compare
8d33e80
to
d500c6a
Compare
/lgtm |
@edcdavid: This pull request references CNF-14648 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irinamihai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes ClusterTemplate spec according to requirements. New format is below:
The cluster template validation is updated to include name validation as follows:
Also includes TemplateID validation:
To use the auto generated TemplateID. Do not configure the templateID field at all in the ClusterTemplate object. If configured and empty, GitOps/ArgoCD will try to reconcile it unsuccessfully.
TODO:
unit testsoperator verification: scorecard, manifest, etcsystem testsDebugging Single cluster template commitTesting TemplateID auto creationunit tests for ExtractSubSchema and InsertSubSchemaimprove schema in unit test