Upversion golang to 1.22 #226
Conversation
sudomakeinstall2
force-pushed
the
upversion-golang-1.22
branch
2 times, most recently
from
89f2ea5
to
1fe654c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
You have to also update https://github.com/openshift-kni/oran-o2ims/blob/main/Dockerfile.tools |
sudomakeinstall2
force-pushed
the
upversion-golang-1.22
branch
from
1fe654c
to
e22524a
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
I think https://github.com/openshift-kni/oran-o2ims/blob/main/api/hardwaremanagement/go.mod should probably be updated in this PR as well. In the near future, we should look at creating a check we can include in the ci-job that makes sure this subfolder go.mod aligns with the main one - although that may make it tricky when we add dependbot config |
In order to use IBGU for upgrade, TALM should be added as a dependency. Since TALM is using golang1.22, it is required to upversion golang to 1.22 Signed-off-by: Saeid Askari <[email protected]>
sudomakeinstall2
force-pushed
the
upversion-golang-1.22
branch
from
e22524a
to
a01fb73
Compare
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
| go 1.21 | ||
| go 1.22.0 | ||
|
|
||
| toolchain go1.22.8 | ||
|
|
There was a problem hiding this comment.
Do we still need the k8s.io/api and k8s.io/client-go replace directives? These are go-1.20 modules:
https://github.com/kubernetes/api/blob/v0.28.2/go.mod
https://github.com/kubernetes/client-go/blob/v0.28.2/go.mod
I guess we need to check the siteconfig operator dependencies here. Maybe we can update or remove the related replace directive completely?
The latest siteconfig operator is go-1.21, but still uses the 0.28.2 api and client-go.
There was a problem hiding this comment.
There was a problem hiding this comment.
I created a PR to remove the directive from siteconfig. However TALM has one of these directives, and it needs quite a bit of work to remove. It needs complicated code changes.
Maybe if move our APIs to a separate repo we could avoid these issues.
There was a problem hiding this comment.
You could do as we've done in this repo, creating go submodules for the exported APIs. The oran-hwmgr-plugin is able to import just the api/hardwaremanagement folder, for example, without then pulling in all the dependencies from the main oran-o2ims go.mod
In order to use IBGU for upgrade, TALM should be added as a dependency. Since TALM is using golang1.22, it is required to upversion golang to 1.22.