Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Introduce script to sync submodule dependencies #231

Closed
wants to merge 1 commit into from

Conversation

donpenney
Copy link
Collaborator

This update adds a script to sync the dependencies of exported submodules against the main go.mod.

Additionally, shellcheck and bashate are added to ci-job.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2024
@openshift-ci-robot
Copy link
Collaborator

@donpenney: This pull request explicitly references no jira issue.

In response to this:

This update adds a script to sync the dependencies of exported submodules against the main go.mod.

Additionally, shellcheck and bashate are added to ci-job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Oct 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from donpenney. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@donpenney
Copy link
Collaborator Author

/test all

@donpenney donpenney force-pushed the sync-submodules branch 2 times, most recently from 9bc13bc to 7ce8e43 Compare October 3, 2024 17:51
@donpenney
Copy link
Collaborator Author

/test all

@donpenney
Copy link
Collaborator Author

/test all

1 similar comment
@donpenney
Copy link
Collaborator Author

/test all

@donpenney
Copy link
Collaborator Author

/retest

@donpenney donpenney marked this pull request as ready for review October 3, 2024 19:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2024
@donpenney
Copy link
Collaborator Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2024
This update adds a script to sync the dependencies of exported
API submodules against the main go.mod.

Signed-off-by: Don Penney <[email protected]>
@donpenney
Copy link
Collaborator Author

This is being dropped in favour of using go workspaces after the upgrade to 1.22

@donpenney donpenney closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants