Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KNI] Dockerfile: drop python2 #117

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

swatisehgal
Copy link
Collaborator

@swatisehgal swatisehgal commented Jul 31, 2023

Python2 no longer needed and its presence is causing CI failure in #116.

@openshift-ci openshift-ci bot requested review from MarSik and yanirq July 31, 2023 13:27
@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani
Copy link
Member

/approve
/lgtm

thanks!

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

@swatisehgal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-unit b640f8d link true /test ci-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ffromani ffromani merged commit 1161ea7 into openshift-kni:master Jul 31, 2023
3 checks passed
@swatisehgal swatisehgal deleted the drop-python branch July 31, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants